linux-kernel - Re: [PATCH v2] x86: fix output of show_stack_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1424459742.18211.13.camel@perches.com>
Date:	Fri, 20 Feb 2015 11:15:42 -0800
From:	Joe Perches <joe@...ches.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andy Lutomirski <luto@...capital.net>,
	Francesco Ruggeri <fruggeri@...sta.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Andrey Ryabinin <a.ryabinin@...sung.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Anvin <hpa@...or.com>,
	Adrien Schildknecht <adrien+dev@...ischi.me>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alexander van Heukelum <heukelum@...tmail.fm>,
	Borislav Petkov <bp@...en8.de>,
	Andrey Konovalov <adech.fo@...il.com>,
	the arch/x86 maintainers <x86@...nel.org>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v2] x86: fix output of show_stack_log_lvl()

On Fri, 2015-02-20 at 10:51 -0800, Linus Torvalds wrote:
> On Fri, Feb 20, 2015 at 10:03 AM, Joe Perchens <joe@...ches.com> wrote:
> >
> > True. Also fix the pr_debug/dev_dbg cases
> > like drivers/dma/ppc4xx/adma.c:
> 
> Yup, that's just garbage, and doesn't actually do what is intended.
> 
> Also, rather than
> 
>          pr_debug("\n%s(%d):\nsrc: ", __func__, id);
>          for (i = 0; i < src_cnt; i++)
>                  pr_debug("\t0x%016llx ", src[i]);
>         ...
> 
> t should probably just use
> 
>          pr_debug("%s(%d):\n", __func__, id);
>          pr_debug("%src: %*phN\n", src_cnt*sizeof(*src), src);
> 
> or similar. Yes, that will just print out the byte-stream rather than
> do it in chunkcs of 64-bit entries, but..

That won't work for > 64 byte output.

This would probably be better:

	print_hex_dump_debug("src: ", DUMP_PREFIX_OFFSET, 16, sizeof(*src),
			     src, src_cnt * sizeof(*src), false);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/