lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Feb 2015 15:50:08 -0500 (EST) From: David Miller <davem@...emloft.net> To: geert@...ux-m68k.org Cc: therbert@...gle.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: Initialize all members in skb_gro_remcsum_init() From: Geert Uytterhoeven <geert@...ux-m68k.org> Date: Wed, 18 Feb 2015 11:38:06 +0100 > skb_gro_remcsum_init() initializes the gro_remcsum.delta member only, > leading to compiler warnings about a possibly uninitialized > gro_remcsum.offset member: > > drivers/net/vxlan.c: In function ‘vxlan_gro_receive’: > drivers/net/vxlan.c:602: warning: ‘grc.offset’ may be used uninitialized in this function > net/ipv4/fou.c: In function ‘gue_gro_receive’: > net/ipv4/fou.c:262: warning: ‘grc.offset’ may be used uninitialized in this function > > While these are harmless for now: > - skb_gro_remcsum_process() sets offset before changing delta, > - skb_gro_remcsum_cleanup() checks if delta is non-zero before > accessing offset, > it's safer to let the initialization function initialize all members. > > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org> Applied, thank you.
Powered by blists - more mailing lists