linux-kernel - Re: [PATCH] mfd: arizona: Move useful defines into a dt-binding include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 21 Feb 2015 18:23:08 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	lee.jones@...aro.org, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.ok,
	galak@...eaurora.org, sameo@...ux.intel.org, lgirdwood@...il.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] mfd: arizona: Move useful defines into a dt-binding
 include

On Wed, Feb 18, 2015 at 11:03:39AM +0000, Charles Keepax wrote:

> --- a/include/linux/mfd/arizona/pdata.h
> +++ b/include/linux/mfd/arizona/pdata.h
> @@ -7,61 +7,17 @@
>   * it under the terms of the GNU General Public License version 2 as
>   * published by the Free Software Foundation.
>   */
> +#include <dt-bindings/mfd/arizona.h>
>  
>  #ifndef _ARIZONA_PDATA_H
>  #define _ARIZONA_PDATA_H

It's a bit odd to have the include outside the guards, is there any
great reason for doing so?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)