linux-kernel - Re: [PATCH] spi: sirf: add reset controller dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150221094458.GM6236@finisterre.sirena.org.uk>
Date:	Sat, 21 Feb 2015 18:44:58 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Barry Song <Baohua.Song@....com>, linux-kernel@...r.kernel.org,
	linux-spi@...r.kernel.org, Philipp Zabel <p.zabel@...gutronix.de>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Marek Vasut <marex@...x.de>, Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [PATCH] spi: sirf: add reset controller dependency

On Thu, Feb 19, 2015 at 04:01:29PM +0100, Arnd Bergmann wrote:

> So the stubs are provided for all functions except device_reset() and
> reset_control_get(), and drivers using the API need to either call the
> stubbed-out _optional() versions of these functions or have the explicit
> dependency.

In that case a dependency seems wrong, I'd expect to see a select - it's
a bit obscure to have to grovel around to figure out what magic options
are needed to make things turn on and resets feel more like a utility
thing than a control bus (which tend to be the things we depend on).
Dunno, perhaps I'm wrong?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)