linux-kernel - Re: [GIT PULL] time/ntp fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150221054901.GA21071@gmail.com>
Date:	Sat, 21 Feb 2015 06:49:02 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	John Stultz <john.stultz@...aro.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] time/ntp fix


* John Stultz <john.stultz@...aro.org> wrote:

> On Fri, Feb 20, 2015 at 2:26 PM, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
> > On Fri, Feb 20, 2015 at 5:44 AM, Ingo Molnar <mingo@...nel.org> wrote:
> >>
> >> John Stultz (1):
> >>       ntp: Fixup adjtimex freq validation on 32-bit systems
> >
> > This is confusing. 32-bit?
> 
> Right, so the check that was added in a previous commit 
> is really only a concern for 64bit systems, but was 
> applied to both 32 and 64bit systems, which results in 
> breaking 32bit systems.
> 
> Thus the "fix" here is to make the check only apply to 
> 64bit systems.

Yeah, perhaps a better commit title would have been to 
write:

     time/ntp: Fix adjtimex freq validation code build warning on 32-bit systems

To make it clear that the problem fixed is a 32-bit 
warning, and that the fix for that is to only check on 
64-bit systems.

I agreed with your BITS_PER_LONG check when I reviewed your 
patch, people usually do an ugly #ifdef, I think this 
in line check form is nicer.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/