lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Feb 2015 16:31:20 -0800 From: Tolga Ceylan <tolga.ceylan@...il.com> To: Joe Perches <joe@...ches.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Roxana Blaj <roxanagabriela10@...il.com>, Ana Rey <anarey@...il.com>, Rui Miguel Silva <rmfrfs@...il.com>, Chaitra Ramaiah <linux.delve@...il.com>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, Larry Finger <Larry.Finger@...inger.net> Subject: Re: [PATCH 4/4] Staging: rtl8192u: r819xU_firmware: added space after comma On Fri, Feb 20, 2015 at 11:47 AM, Tolga Ceylan <tolga.ceylan@...il.com> wrote: > On Thu, Feb 19, 2015 at 11:30 PM, Joe Perches <joe@...ches.com> wrote: >> >> Might as well remove the unnecessary cast too: >> >> memcpy(skb->cb, &dev, sizeof(dev)); >> >> but it might be better to avoid the memcpy and use an assign >> >> *(struct net_device *)skb->cb = dev; >> > Should I sent a new set of patches (including memcpy change)? Or reply to the series with a single memcpy change patch? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists