linux-kernel - Re: [PATCH v2] iio: common: ssp_sensors: Protect PM-only functions to kill warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 22 Feb 2015 09:48:03 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Karol Wrona <k.wrona@...sung.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>
CC:	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: common: ssp_sensors: Protect PM-only functions
 to kill warning

On 18/02/15 12:41, Karol Wrona wrote:
> On 02/18/2015 12:39 PM, Geert Uytterhoeven wrote:
>> If CONFIG_PM_SLEEP=n:
>>
>>     drivers/iio/common/ssp_sensors/ssp_dev.c:644: warning: ‘ssp_suspend’ defined but not used
>>     drivers/iio/common/ssp_sensors/ssp_dev.c:669: warning: ‘ssp_resume’ defined but not used
>>
>> Protect the unused functions by #ifdef CONFIG_PM_SLEEP to fix this.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>> ---
>> v2:
>>   - Fix driver name in one-line summary
>> ---
>>  drivers/iio/common/ssp_sensors/ssp_dev.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
>> index 52d70435f5a11c55..55a90082a29bd484 100644
>> --- a/drivers/iio/common/ssp_sensors/ssp_dev.c
>> +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
>> @@ -640,6 +640,7 @@ static int ssp_remove(struct spi_device *spi)
>>  	return 0;
>>  }
>>  
>> +#ifdef CONFIG_PM_SLEEP
>>  static int ssp_suspend(struct device *dev)
>>  {
>>  	int ret;
>> @@ -688,6 +689,7 @@ static int ssp_resume(struct device *dev)
>>  
>>  	return 0;
>>  }
>> +#endif /* CONFIG_PM_SLEEP */
>>  
>>  static const struct dev_pm_ops ssp_pm_ops = {
>>  	SET_SYSTEM_SLEEP_PM_OPS(ssp_suspend, ssp_resume)
>>
> 
> Acked-by: Karol Wrona <k.wrona@...sung.com>
Applied to the fixes-post-3.20-rc1 branch which I'll sort out once rc1 is
tagged.

Thanks,

Jonathan
> 
> Thanks for doing that.
> Karol
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/