linux-kernel - Re: [PATCH 24/27] tracing: Remove use of seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1424601578.20944.12.camel@perches.com>
Date:	Sun, 22 Feb 2015 02:39:38 -0800
From:	Joe Perches <joe@...ches.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 24/27] tracing: Remove use of seq_printf return value

On Sun, 2015-02-22 at 04:41 +0000, Al Viro wrote:
> On Sat, Feb 21, 2015 at 10:54:09PM -0500, Steven Rostedt wrote:
> > On Sat, 21 Feb 2015 18:53:51 -0800 Joe Perches <joe@...ches.com> wrote:
> > 
> > > The seq_printf return value, because it's frequently misused,
> > > will eventually be converted to void.
> > > 
> > > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
> > >      seq_has_overflowed() and make public")
> > > 
> > > Miscellanea:
> > > 
> > > o Remove unused return value from trace_lookup_stack
> > 
> > Acked-by: Steven Rostedt <rostedt@...dmis.org>
> 
> FWIW, this one should be Cc:stable - it's a plain and simple bugfix
> (so are all of those that used to return the result of seq_printf() from
> ->show()).

Nah, it's not really a bugfix here.

Patches sent to stable should fix actual bugs or failures.

Sure, it's a defect, but it's only a logical one, not an
actual one.  It doesn't/can't fail in practice.

This is only a single symbol and so it can't overflow the
initial allocation.

Besides that, the return value of the containing function
is ignored.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/