linux-kernel - Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201502221204.24003@pali>
Date:	Sun, 22 Feb 2015 12:04:23 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Gabriele Mazzotta <gabriele.mzt@...il.com>
Cc:	mjg59@...f.ucam.org, dvhart@...radead.org,
	linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	A.Sloman@...bham.ac.uk, computersforpeace@...il.com,
	dan.carpenter@...cle.com
Subject: Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

On Thursday 19 February 2015 11:58:29 Gabriele Mazzotta wrote:
> This patch adds the support for the configuration of the
> keyboard backlight on supported Dell laptops.
> 
> With this patch it is possible to set:
> * keyboard backlight level
> * timeout after which the backlight will be automatically
> turned off * input activity triggers (keyboard, touchpad,
> mouse) that enable the backlight * ambient light settings
> 
> The settings are exposed via
> /sys/class/leds/dell::kbd_backlight/
> 
> The code is based on the newly released documentation by Dell
> in the libsmbios project.
> 
> Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>
> Cc: Dan Carpenter <dan.carpenter@...cle.com>
> ---
>  .../ABI/testing/sysfs-platform-dell-laptop         |   69 ++
>  drivers/platform/x86/dell-laptop.c                 | 1089
> +++++++++++++++++++- 2 files changed, 1152 insertions(+), 6
> deletions(-)
>  create mode 100644
> Documentation/ABI/testing/sysfs-platform-dell-laptop
> 

This patch is same as combination of previous, just contains all 
changes in single patch file. Difference between v3.19-rc5 and 
current version is just als code was moved to separate functions 
and als backlight can be enabled via new sysfs attribute (like in 
second patch which was sent).

I tested this patch on top of linus tree (commit 79513d0) and 
keyboard backlight works fine.

Darren, what do you think, can be this patch which brings 
keyboard backlight support finally moved to mainline kernel?

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)