linux-kernel - Re: i8k: move driver from char to hwmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54EA12DC.1000403@roeck-us.net>
Date:	Sun, 22 Feb 2015 09:33:16 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Pali Rohár <pali.rohar@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Steven Honeyman <stevenhoneyman@...il.com>,
	Jean Delvare <jdelvare@...e.de>, Valdis.Kletnieks@...edu,
	Jochen Eisinger <jochen@...guin-breeder.org>,
	Gabriele Mazzotta <gabriele.mzt@...il.com>,
	linux-kernel@...r.kernel.org, lm-sensors@...sensors.org
Subject: Re: i8k: move driver from char to hwmon

On 02/22/2015 03:50 AM, Pali Rohár wrote:
> Hello,
>
> currently i8k driver for DELLDIAG SMM operations (charger,
> battery, hotkeys, temperature and fan control) supports two
> interfaces:
>
> 1) old /proc/i8k char device
> 2) new hwmon interface
>
> Driver now lives in char subsystem, but nowadays I think lot of
> people are interested only in hwmon interface which provides
> temperature & fan control. Power management and hotkeys support
> (which is missing in 2) but provided by 1)) is already handled by
> ACPI or input subsystem for new laptops.
>
> Also name "i8k" is really non intuitive what it means and
> supports... (I was told it is abbreviation for Inspirion 8000
> model which was probably first dell model supported by that
> DELLDIAG interface). Now driver is used on Vostro, Latitude and
> also Precision and XPS models. I think at least "dell" should be
> part of driver name and config option.
>
> So I have idea for some changes:
>
> 1) Move driver from char subsystem to hwmon
>
I am ok with this one.

> 2) Rename driver from i8k to something like delldiag or dellsmm
>
Might be problematic, as it would break existing configurations
unless you keep the CONFIG_I8K but rename the driver. Driver names
are never perfect, so I would just leave it as is.

> 3) Add new CONFIG_ option to enable/disable /proc/i8k device and
> compile only hwmon interface support

Makes sense. I would suggest to make hwmon suppport the default
and mandatory if the driver is enabled and add a new CONFIG_I8K_PROCIF
or similar which should be enabled by default.

Are you interested in adding yourself as maintainer for this driver ?

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/