linux-kernel - Re: [PATCH 24/27] tracing: Remove use of seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150221225409.417968db@grimm.local.home>
Date:	Sat, 21 Feb 2015 22:54:09 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 24/27] tracing: Remove use of seq_printf return value

On Sat, 21 Feb 2015 18:53:51 -0800
Joe Perches <joe@...ches.com> wrote:

> The seq_printf return value, because it's frequently misused,
> will eventually be converted to void.
> 
> See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
>      seq_has_overflowed() and make public")
> 
> Miscellanea:
> 
> o Remove unused return value from trace_lookup_stack

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve

> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  kernel/trace/trace_stack.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c
> index c3e4fcf..3f34496 100644
> --- a/kernel/trace/trace_stack.c
> +++ b/kernel/trace/trace_stack.c
> @@ -327,11 +327,11 @@ static void t_stop(struct seq_file *m, void *p)
>  	local_irq_enable();
>  }
>  
> -static int trace_lookup_stack(struct seq_file *m, long i)
> +static void trace_lookup_stack(struct seq_file *m, long i)
>  {
>  	unsigned long addr = stack_dump_trace[i];
>  
> -	return seq_printf(m, "%pS\n", (void *)addr);
> +	seq_printf(m, "%pS\n", (void *)addr);
>  }
>  
>  static void print_disabled(struct seq_file *m)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/