linux-kernel - Re: [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Feb 2015 11:09:05 +0100
From:	Bastien Nocera <hadess@...ess.net>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	Darren Hart <dvhart@...radead.org>,
	ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>
Subject: Re: [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys

On Fri, 2015-02-20 at 11:27 -0800, Andy Lutomirski wrote:
> On 02/20/2015 06:44 AM, Bastien Nocera wrote:
> > +		KEY_MICCANCEL_MODE,  /* Microphone cancellation */
> 
> What's this?  We already have KEY_MICMUTE.  Is this different?  If so, 
> can you improve the comment a bit?

I don't think the comment needs improving. This is the device driver
part of the patch series. If comment was required, it would in the
commit adding the keycode to input.h. We're discussing that with Dmitry.

> The answer may be obvious to anyone who has an awful X1 carbon gen 2 
> keyboard, but these KEY_XYZ defines should IMO be clear enough that even 
> people without the hardware can figure out what's going on.

I'll make sure to link this in the input.h patch:
http://www.lenovo.com/shop/americas/content/user_guides/x1carbon_2_ug_en.pdf

In any case, it doesn't look like this particular keycode will make it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/