linux-kernel - Re: [PATCH 5/6] input: Add keycodes used by Lenovo Carbon X1 2014

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1424691695.28361.15.camel@hadess.net>
Date:	Mon, 23 Feb 2015 12:41:35 +0100
From:	Bastien Nocera <hadess@...ess.net>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	Darren Hart <dvhart@...radead.org>,
	ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org
Subject: Re: [PATCH 5/6] input: Add keycodes used by Lenovo Carbon X1 2014

On Mon, 2015-02-23 at 07:49 -0300, Henrique de Moraes Holschuh wrote:
> On Mon, Feb 23, 2015, at 07:15, Bastien Nocera wrote:
> > On Wed, 2015-02-18 at 21:34 -0200, Henrique de Moraes Holschuh wrote:
> > > On Wed, 18 Feb 2015, Bastien Nocera wrote:
> > > > Signed-off-by: Bastien Nocera <hadess@...ess.net>
> > > 
> > > This one requires an ACK from the input maintainers, or no go...
> > 
> > Any comments about the other patches?
> 
> The series looks mostly good, but the new keymap and attributes need to
> go
> in the driver documentation (Documentation/laptops/thinkpad-acpi.txt),
> and some
> of the commit decriptions could use an update.
> 
> You could opt to change some of those keypresses dinamically into
> driver-specific
> ACPI events, by setting the keymap entry to KEY_RESERVED.  The driver
> will
> issue HKEY events in that case. That will be an viable alternative for
> some of the new
> keys.

I don't understand what you mean here.

> The beauty of it is that keymaps are configurable in run-time, so
> userspace can
> just set any key entries it wants to change to something else, and ACPI
> events will be
> suppressed if the entry is not set to KEY_RESERVED anymore.

Keymaps are already configurable at run-time, that's how udev changes
keymaps. Or did you mean something else?

> We need to be careful with tpacpi_input_send_key_masked(). If any of the
> codepaths
> could call it from the adaptative keyboard handling code,

But we're not calling it from there, are we?

>  it needs to be
> updated (just
> assume anything above 32 is enabled, as the firmware does not have an
> event mask
> for the new keycodes).



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/