linux-kernel - Re: [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150223065102.53c531a1@gandalf.local.home>
Date:	Mon, 23 Feb 2015 06:51:02 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	"Dov Levenglick" <dovl@...eaurora.org>
Cc:	"Gilad Broner" <gbroner@...eaurora.org>,
	james.bottomley@...senpartnership.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, santoshsy@...il.com,
	linux-scsi-owner@...r.kernel.org, subhashj@...eaurora.org,
	ygardi@...eaurora.org, draviv@...eaurora.org,
	"Lee Susman" <lsusman@...eaurora.org>,
	"Sujit Reddy Thumma" <sthumma@...eaurora.org>,
	"Vinayak Holikatti" <vinholikatti@...il.com>,
	"James E.J. Bottomley" <jbottomley@...allels.com>,
	"Ingo Molnar" <mingo@...hat.com>
Subject: Re: [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for
 debug

On Mon, 23 Feb 2015 09:15:15 -0000
"Dov Levenglick" <dovl@...eaurora.org> wrote:

[ Cut's a 1000 lines of unneeded patch ]

> > +#endif /* if !defined(_TRACE_UFS_H) || defined(TRACE_HEADER_MULTI_READ)
> > */
> > +
> > +/* This part must be outside protection */
> > +#include <trace/define_trace.h>
> > --
> > Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> 
> Reviewed-by: Dov Levenglick <dovl@...eaurora.org>

Please, when you add a tag, do it just under the change log, not the
bottom of the patch. And cut out most of the text that people can read
your email on a single page.

It is extremely annoying to scroll down a 1000 lines to find no
comments and just someone giving their "Reviewed-by" tag.

-- Steve

> 
> QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/