linux-kernel - Re: 3.19: Sony playstation controller causes kernel oops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1502231301360.19920@pobox.suse.cz>
Date:	Mon, 23 Feb 2015 13:02:41 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	David Herrmann <dh.herrmann@...il.com>
cc:	Pavel Machek <pavel@....cz>,
	kernel list <linux-kernel@...r.kernel.org>,
	"open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
	rydberg@...math.org, Frank Praznik <frank.praznik@...rr.com>
Subject: Re: 3.19: Sony playstation controller causes kernel oops

On Mon, 23 Feb 2015, David Herrmann wrote:

> Hi Jiri
> 
> On Sun, Feb 22, 2015 at 10:50 PM, Jiri Kosina <jkosina@...e.cz> wrote:
> > [ some CCs added and full dmesg kept for reference ]
> >
> > On Sun, 22 Feb 2015, Pavel Machek wrote:
> >
> >> Hi!
> >>
> >> I plugged in part of PS move to the PC, to let it charge. Got: full
> >> dmesg in attachment. I believe I charged it in PC before, but it may
> >> be year ago or more.
> >>
> >> Ideas?
> >
> > Ok, this is embarassing. I guess the patch below fixes it, right? (the
> > spinlock got introduced in d2d782fccee, so I guess you didn't have it a
> > year ago)
> >
> > diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
> > index 31e9d25..3756a62 100644
> > --- a/drivers/hid/hid-sony.c
> > +++ b/drivers/hid/hid-sony.c
> > @@ -2140,6 +2140,7 @@ static int __init sony_init(void)
> >  {
> >         dbg_hid("Sony:%s\n", __func__);
> >
> > +       spin_lock_init(&sony_dev_list_lock);
> >         return hid_register_driver(&sony_driver);
> >  }
> 
> Nice catch. I'd prefer the patch below, though. For both:
> Reviewed-by: David Herrmann <dh.herrmann@...il.com>

Thanks. I already used the DEFINE_SPINLOCK() variant and pushed it 
our earlier today.

There was also missing sc->lock initialization in per-device probe, Frank 
sent patch for that as well.

Both now applied and pushed out.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/