linux-kernel - Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Feb 2015 14:57:08 +0200
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Stanimir Varbanov <svarbanov@...sol.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Kumar Gala <galak@...eaurora.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms


On Wed, 2015-02-04 at 19:46 +0100, Paul Bolle wrote:
> On Wed, 2015-02-04 at 17:27 +0200, Stanimir Varbanov wrote:
> > On 02/04/2015 05:14 PM, Paul Bolle wrote:
> > > On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote:
> > > > On 02/03/2015 10:42 PM, Paul Bolle wrote:
> > > > > On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
> > > > > > diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
> > > > > > index bf1295e..115348c 100644
> > > > > > --- a/drivers/spmi/Kconfig
> > > > > > +++ b/drivers/spmi/Kconfig
> > > > > > @@ -12,7 +12,7 @@ if SPMI
> > > > > > 
> > > > > >  config SPMI_MSM_PMIC_ARB
> > > > > >         tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
> > > > > > -       depends on ARM
> > > > > > +       depends on ARM || ARM64
> > > > > >         depends on IRQ_DOMAIN
> > > > > >         depends on ARCH_QCOM || COMPILE_TEST
> > > > > >         default ARCH_QCOM
> > > > > 
> > > > > But only if COMPILE_TEST is set too, isn't it? Is that intended?
> > > > 
> > > > No, the driver will be used on arm64 qcom platforms, also.
> > > 
> > > But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it?
> > 
> > Currently yes, but we want to be prepared to support PMIC's which will
> > be used on arm64 platforms, although they are not upstream yet.
> 
> Please make the commit summary reflect that, as in:
>     "spmi: pmic_arb: enable test build on arm64"
> 
> Commit explanation likewise.

What if we just drop ARM dependency? 

Regards,
Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/