linux-kernel - Re: [Patch v2 1/3] firmware: dmi_scan: fix dmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150223134243.GB19367@codeblueprint.co.uk>
Date:	Mon, 23 Feb 2015 13:42:43 +0000
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
Cc:	ard.biesheuvel@...aro.org, leif.lindholm@...aro.org,
	linux-kernel@...r.kernel.org
Subject: Re: [Patch v2 1/3] firmware: dmi_scan: fix dmi_len type

On Wed, 18 Feb, at 01:33:19PM, Ivan Khoronzhuk wrote:
> According to SMBIOSv3 specification the length of DMI table can be
> up to 32bits wide. So use appropriate type to avoid overflow.
> 
> It's obvious that dmi_num theoretically can be more than u16 also,
> so it's can be changed to u32 or at least it's better to use int
> instead of u16, but on that moment I cannot imagine dmi structure
> count more than 65535 and it can require changing type of vars that
> work with it. So I didn't correct it.
> 
> Acked-by: Ard Biesheuvel <ard@...aro.org>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
> ---
>  drivers/firmware/dmi_scan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to the 'urgent' EFI branch and tagged for stable. Thanks Ivan.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/