linux-kernel - Re: [PATCH] arch: mips: kvm: Enable after disabling interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150223140717.GI9453@jhogan-linux.le.imgtec.org>
Date:	Mon, 23 Feb 2015 14:07:17 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	Tapasweni Pathak <tapaswenipathak@...il.com>
CC:	<gleb@...nel.org>, <pbonzini@...hat.com>, <ralf@...ux-mips.org>,
	<kvm@...r.kernel.org>, <linux-mips@...ux-mips.org>,
	<linux-kernel@...r.kernel.org>, <julia.lawall@...6.fr>
Subject: Re: [PATCH] arch: mips: kvm: Enable after disabling interrupt

On Sun, Feb 22, 2015 at 09:48:21PM +0530, Tapasweni Pathak wrote:
> Enable disabled interrupt, on unsuccessful operation.
> 
> Found by Coccinelle.
> 
> Signed-off-by: Tapasweni Pathak <tapaswenipathak@...il.com>
> Acked-by: Julia Lawall <julia.lawall@...6.fr>

Reviewed-by: James Hogan <james.hogan@...tec.com>

Cheers
James

> ---
>  arch/mips/kvm/tlb.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/kvm/tlb.c b/arch/mips/kvm/tlb.c
> index bbcd822..b6beb0e 100644
> --- a/arch/mips/kvm/tlb.c
> +++ b/arch/mips/kvm/tlb.c
> @@ -216,6 +216,7 @@ int kvm_mips_host_tlb_write(struct kvm_vcpu *vcpu, unsigned long entryhi,
>  	if (idx > current_cpu_data.tlbsize) {
>  		kvm_err("%s: Invalid Index: %d\n", __func__, idx);
>  		kvm_mips_dump_host_tlbs();
> +		local_irq_restore(flags);
>  		return -1;
>  	}
> 
> --
> 1.7.9.5
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)