linux-kernel - Re: [PATCH] x86_64: use kstack_end() in dumpstack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150223125411.323330f8@gandalf.local.home>
Date:	Mon, 23 Feb 2015 12:54:11 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Adrien Schildknecht <adrien+dev@...ischi.me>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, srostedt@...hat.com, luto@...capital.net,
	bp@...en8.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86_64: use kstack_end() in dumpstack_64.c

On Mon, 23 Feb 2015 18:29:05 +0100
Adrien Schildknecht <adrien+dev@...ischi.me> wrote:

> > > This patch depends on patch "x86: fix output of
> > > show_stack_log_lvl()"
> > 
> > I'm curious to what the dependency is? What would break if we apply
> > this without that patch?
> 
> Maybe I misunderstood "dependency".
> I mean that this patch won't apply properly since a line of the context
> was changed by the previous patch.
> "if ((i % STACKSLOTS_PER_LINE) == 0) {"
> 

Yeah, "dependency" is a bit ambiguous here. It can mean both "this
patch wont work without said patch" as well as "this patch wont apply
without said patch". Probably would have been better to say that it
won't apply to avoid the ambiguity.

Also, these types of notes are best stated after the '---' line. As
it's good information for the maintainer pulling in the patch, but
should not go in the change log. Same for comments like "Changes since
version 1 of this series".

That is:

i386 is already using kstack_end() in dumpstack_32.c.
We should also use it to make the code clearer and unify the stack
printing logic some more.

Signed-off-by: Adrien Schildknecht <adrien+dev@...ischi.me>
---
Note: This patch depends on patch "x86: fix output of show_stack_log_lvl()"
or it might not apply properly.

 arch/x86/kernel/dumpstack_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

The change log for the above stops at the '---'.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/