linux-kernel - Re: [PATCH 3/6] thinkpad_acpi: Add adaptive_kbd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Feb 2015 19:18:33 +0100
From:	Bastien Nocera <hadess@...ess.net>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	Darren Hart <dvhart@...radead.org>,
	ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org
Subject: Re: [PATCH 3/6] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

On Mon, 2015-02-23 at 14:00 -0300, Henrique de Moraes Holschuh wrote:
> On Fri, Feb 20, 2015, at 02:28, Darren Hart wrote:
> > On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote:
> > 
> > Commit message please.
> > 
> > > Signed-off-by: Bastien Nocera <hadess@...ess.net>
> > > ---
> > >  drivers/platform/x86/thinkpad_acpi.c | 71 +++++++++++++++++++++++++++++++-----
> > >  1 file changed, 62 insertions(+), 9 deletions(-)
> > > 
> > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> > > index a6dd017..562d958 100644
> > > --- a/drivers/platform/x86/thinkpad_acpi.c
> > > +++ b/drivers/platform/x86/thinkpad_acpi.c
> > 
> > ...
> > 
> > > +static struct device_attribute dev_attr_adaptive_kbd_mode =
> > > +	__ATTR(adaptive_kbd_mode, S_IWUSR | S_IRUGO,
> > > +		adaptive_kbd_mode_show, adaptive_kbd_mode_store);
> > > +
> > 
> > Please use DEVICE_ATTR_RW() macros for new sysfs files.
> > 
> > I'd very much like to see a cleanup of the driver to use these as well.
> > 
> > Henrique, your thoughts / preference?
> 
> Converting to DEVICE_ATTR_RW/RO would be welcome.

I've already sent the new patch for that though...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/