linux-kernel - Re: fs: dax: do not build on ARC or SH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150223215634.GA23928@roeck-us.net>
Date:	Mon, 23 Feb 2015 13:56:34 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Matthew Wilcox <willy@...ux.intel.com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-sh@...r.kernel.org, Vineet Gupta <vgupta@...opsys.com>
Subject: Re: fs: dax: do not build on ARC or SH

On Mon, Feb 23, 2015 at 01:40:25PM -0500, Matthew Wilcox wrote:
> On Mon, Feb 23, 2015 at 12:29:45PM +0100, Arnd Bergmann wrote:
> > The DAX implementation relies on the architecture to provide a working
> > copy_user_page() function, as reported by Michael Ellerman's kisskb
> > build bot:
> > 
> > fs/dax.c: error: implicit declaration of function 'copy_user_page' [-Werror=implicit-function-declaration]:  => 266:2
> > 
> > We already have a list of architectures that are known to be incompatible,
> > but the list is missing ARC and SH at the moment. Further, blackfin and
> > c6x also lack support for this function, but are already excluded because
> > they do not support MMU-based kernels.
> 
> I've got a short list of patches for DAX; I'll add this one to the list.
> 
> Have the maintainers of these architectures been notified that they're
> missing a core piece of kernel functionality?
> 

Guess there a philosophical difference in opinion if the architecture code
should (have to) provide copy_user_page() or not outside the architecture
code itself. After all, fs/dax.c _is_ the only user of this function outside
the architecture code.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/