linux-kernel - Re: [PATCH net-next] altera_tse: Fixes in NAPI and interrupt handling paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150223.180815.2270832900387656053.davem@davemloft.net>
Date:	Mon, 23 Feb 2015 18:08:15 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	vbridger@...nsource.altera.com
Cc:	netdev@...r.kernel.org, nios2-dev@...ts.rocketboards.org,
	linux-kernel@...r.kernel.org, vbridger@...era.com, setka@...s.cz,
	rpisl@....zcu.cz
Subject: Re: [PATCH net-next] altera_tse: Fixes in NAPI and interrupt
 handling paths

From: Vince Bridgers <vbridger@...nsource.altera.com>
Date: Mon, 23 Feb 2015 11:30:29 -0600

> From: Vlastimil Setka <setka@...s.cz>
> 
> Incorrect NAPI polling caused WARNING at net/core/dev.c net_rx_action.
> Some stability issues were also seen at high throughput and system
> load before this patch.
> 
> This patch contains several changes in altera_tse_main.c:
> 
> - tse_rx() is fixed to not process more than `limit` frames
> 
> - tse_poll() is refactored to match NAPI logic
>   - only received frames are counted for return value
>   - removed bogus condition `(rxcomplete >= budget || txcomplete > 0)`
>   - replace by: if (rxcomplete < budget) -> call __napi_complete and enable irq
> 
> - altera_isr()
>   - replace spin_lock_irqsave() by spin_lock() - we are in isr
>   - use spinlocks just over irq manipulation, not over __napi_schedule
>   - reset IRQ first, then disable and schedule napi
> 
> This is a cleaned up resubmission from Vlastimil's recent submission.
> 
> Signed-off-by: Vlastimil Setka <setka@...s.cz>
> Signed-off-by: Roman Pisl <rpisl@....zcu.cz>
> Signed-off-by: Vince Bridgers <vbridger@...nsource.altera.com>

This is also a bug fix, and therefore not appropriate to target at 'net-next'.

I've applied it to 'net' instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/