linux-kernel - Re: [PATCH 12/35] clockevents: Provide explicit broadcast control function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150224003848.GL32521@atomide.com>
Date:	Mon, 23 Feb 2015 16:38:49 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...nel.org, rjw@...ysocki.net,
	tglx@...utronix.de, Fenghua Yu <fenghua.yu@...el.com>,
	Len Brown <lenb@...nel.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>
Subject: Re: [PATCH 12/35] clockevents: Provide explicit broadcast control
 function

* Peter Zijlstra <peterz@...radead.org> [150216 05:13]:
> From: Thomas Gleixner <tglx@...utronix.de>
> 
> clockevents_notify() is a leftover from the early design of the
> clockevents facility. It's really not a notification mechanism, it's a
> multiplex call. We are way better off to have explicit calls instead of this
> monstrosity.
> 
> Split out the broadcast control into a separate function and provide
> inline helpers. Switch clockevents_notify() over. This will go away
> once all callers are converted.
> 
> This also gets rid of the nested locking of clockevents_lock and
> broadcast_lock. The broadcast control functions do not require
> clockevents_lock. Only the managing functions
> (setup/shutdown/suspend/resume of the broadcast device require 
> clockevents_lock.

Seems to still behave for my off-idle PM tests after a quick
try on Peter's timers/core branch. Might be too late, but just
in case it's not:

Tested-by: Tony Lindgren <tony@...mide.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/