linux-kernel - Re: [PATCH 25/35] ARM: OMAP: Use explicit broadcast oneshot control function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150224004157.GO32521@atomide.com>
Date:	Mon, 23 Feb 2015 16:41:57 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...nel.org, rjw@...ysocki.net,
	tglx@...utronix.de
Subject: Re: [PATCH 25/35] ARM: OMAP: Use explicit broadcast oneshot control
 function

* Peter Zijlstra <peterz@...radead.org> [150216 05:13]:
> From: Thomas Gleixner <tglx@...utronix.de>
> 
> Replace the clockevents_notify() call with an explicit function call.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Tony Lindgren <tony@...mide.com>

Works for me:

Tested-by: Tony Lindgren <tony@...mide.com>

> ---
>  arch/arm/mach-omap2/cpuidle44xx.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> Index: linux/arch/arm/mach-omap2/cpuidle44xx.c
> ===================================================================
> --- linux.orig/arch/arm/mach-omap2/cpuidle44xx.c
> +++ linux/arch/arm/mach-omap2/cpuidle44xx.c
> @@ -84,7 +84,6 @@ static int omap_enter_idle_coupled(struc
>  {
>  	struct idle_statedata *cx = state_ptr + index;
>  	u32 mpuss_can_lose_context = 0;
> -	int cpu_id = smp_processor_id();
>  
>  	/*
>  	 * CPU0 has to wait and stay ON until CPU1 is OFF state.
> @@ -112,7 +111,7 @@ static int omap_enter_idle_coupled(struc
>  	mpuss_can_lose_context = (cx->mpu_state == PWRDM_POWER_RET) &&
>  				 (cx->mpu_logic_state == PWRDM_POWER_OFF);
>  
> -	clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &cpu_id);
> +	tick_broadcast_enter();
>  
>  	/*
>  	 * Call idle CPU PM enter notifier chain so that
> @@ -169,7 +168,7 @@ static int omap_enter_idle_coupled(struc
>  	if (dev->cpu == 0 && mpuss_can_lose_context)
>  		cpu_cluster_pm_exit();
>  
> -	clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu_id);
> +	tick_broadcast_exit();
>  
>  fail:
>  	cpuidle_coupled_parallel_barrier(dev, &abort_barrier);
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/