linux-kernel - Re: [PATCH] sunrpc: Fix trace events to store data in the struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150224110718.1404695c@gandalf.local.home>
Date:	Tue, 24 Feb 2015 11:07:18 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	David Ahern <dsahern@...il.com>
Cc:	James Hogan <james.hogan@...tec.com>,
	Jeff Layton <jlayton@...marydata.com>,
	"J. Bruce Fields" <bfields@...hat.com>,
	linux-kernel@...r.kernel.org,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	Ingo Molnar <mingo@...hat.com>, stable@...r.kernel.org
Subject: Re: [PATCH] sunrpc: Fix trace events to store data in the struct

On Tue, 24 Feb 2015 09:03:09 -0700
David Ahern <dsahern@...il.com> wrote:

> On 2/24/15 7:48 AM, Steven Rostedt wrote:
> > I assume that the %pISpc expects a "struct sockaddr" passed to it as
> > that is what is typecast in the print. We might as well make the ss into
> > that structure instead of a struct sockaddr_storage, as it looks like
> > the storage one is much larger, and we only care about the sockaddr
> > part. Let's not waste the ring buffer if we don't need to.
> 
> Per lib/vsprintf.c, it expects either a sockaddr_in or sockaddr_in6:
> 
>                  case 'S': {
>                          const union {
>                                  struct sockaddr         raw;
>                                  struct sockaddr_in      v4;
>                                  struct sockaddr_in6     v6;
>                          } *sa = ptr;
> 
> sockaddr_in6 > sockaddr so ss should be declared accordingly.

Agreed. Thanks for pointing that out.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/