linux-kernel - Re: [PATCH] media: au0828 replace printk KERN_DEBUG with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150224190346.4cf0b439@recife.lan>
Date:	Tue, 24 Feb 2015 19:03:46 -0300
From:	Mauro Carvalho Chehab <mchehab@....samsung.com>
To:	Shuah Khan <shuahkh@....samsung.com>
Cc:	hans.verkuil@...co.com, prabhakar.csengg@...il.com,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: au0828 replace printk KERN_DEBUG with pr_debug

Em Tue, 24 Feb 2015 11:53:34 -0700
Shuah Khan <shuahkh@....samsung.com> escreveu:

> Replace printk KERN_DEBUG with pr_debug in dprintk macro
> defined in au0828.h
> 
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
>  drivers/media/usb/au0828/au0828.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/au0828/au0828.h b/drivers/media/usb/au0828/au0828.h
> index eb15187..e3e90ea 100644
> --- a/drivers/media/usb/au0828/au0828.h
> +++ b/drivers/media/usb/au0828/au0828.h
> @@ -336,7 +336,7 @@ extern struct vb2_ops au0828_vbi_qops;
>  
>  #define dprintk(level, fmt, arg...)\
>  	do { if (au0828_debug & level)\
> -		printk(KERN_DEBUG pr_fmt(fmt), ## arg);\
> +		pr_debug(pr_fmt(fmt), ## arg);\

NACK.

This is the worse of two words, as it would require both to enable
each debug line via dynamic printk setting and to enable au0828_debug.

Regards,
Mauro


>  	} while (0)
>  
>  /* au0828-input.c */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/