linux-kernel - Re: [patch] mm, hugetlb: close race when setting PageTail for gigantic pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <068c01d050a3$57c90eb0$075b2c10$@alibaba-inc.com>
Date:	Wed, 25 Feb 2015 10:32:45 +0800
From:	"Hillf Danton" <hillf.zj@...baba-inc.com>
To:	"'David Rientjes'" <rientjes@...gle.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"'Davidlohr Bueso'" <dave@...olabs.net>,
	"'Luiz Capitulino'" <lcapitulino@...hat.com>,
	"'Joonsoo Kim'" <iamjoonsoo.kim@....com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	<linux-mm@...ck.org>, "Hillf Danton" <hillf.zj@...baba-inc.com>
Subject: Re: [patch] mm, hugetlb: close race when setting PageTail for gigantic pages

> Now that gigantic pages are dynamically allocatable, care must be taken
> to ensure that p->first_page is valid before setting PageTail.
> 
> If this isn't done, then it is possible to race and have compound_head()
> return NULL.
> 
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
Acked-by: Hillf Danton <hillf.zj@...baba-inc.com>

>  mm/hugetlb.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -917,7 +917,6 @@ static void prep_compound_gigantic_page(struct page *page, unsigned long order)
>  	__SetPageHead(page);
>  	__ClearPageReserved(page);
>  	for (i = 1; i < nr_pages; i++, p = mem_map_next(p, page, i)) {
> -		__SetPageTail(p);
>  		/*
>  		 * For gigantic hugepages allocated through bootmem at
>  		 * boot, it's safer to be consistent with the not-gigantic
> @@ -933,6 +932,9 @@ static void prep_compound_gigantic_page(struct page *page, unsigned long order)
>  		__ClearPageReserved(p);
>  		set_page_count(p, 0);
>  		p->first_page = page;
> +		/* Make sure p->first_page is always valid for PageTail() */
> +		smp_wmb();
> +		__SetPageTail(p);
>  	}
>  }
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/