linux-kernel - Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Feb 2015 09:37:25 +0530
From:	Vignesh R <vigneshr@...com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Benoit Cousson <bcousson@...libre.com>,
	Tony Lindgren <tony@...mide.com>,
	Russell King <linux@....linux.org.uk>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Brad Griffis <bgriffis@...com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Sanjeev Sharma <sanjeev_sharma@...tor.com>,
	Jan Kardell <jan.kardell@...liq.com>,
	Felipe Balbi <balbi@...com>, Wolfram Sang <wsa@...-dreams.de>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-iio@...r.kernel.org>, <linux-input@...r.kernel.org>
Subject: Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache
 save

Hi,

On Thursday 05 February 2015 11:51 AM, Vignesh R wrote:
> 
> 
> On Wednesday 21 January 2015 03:44 PM, Vignesh R wrote:
>> On Tuesday 20 January 2015 09:34 PM, Lee Jones wrote:
>>> On Tue, 20 Jan 2015, R, Vignesh wrote:
>>>> On 1/20/2015 5:23 PM, Lee Jones wrote:
>>>>> On Wed, 07 Jan 2015, Vignesh R wrote:
>>>>>
>>>>>> In one shot mode, sequencer automatically disables all enabled steps at
>>>>>> the end of each cycle. (both ADC steps and TSC steps) Hence these steps
>>>>>> need not be saved in reg_se_cache for clearing these steps at a later
>>>>>> stage.
>>>>>> Also, when ADC wakes up Sequencer should not be busy executing any of the
>>>>>> config steps except for the charge step. Previously charge step was 1 ADC
>>>>>> clock cycle and hence it was ignored.
>>>>>> TSC steps are always disabled at the end of each conversion cycle, hence
>>>>>> there is no need to explicitly disable TSC steps by writing 0 to REG_SE.
>>>>>>
>>>>>> Signed-off-by: Vignesh R <vigneshr@...com>
>>>>>> ---
>>>>>>
>>>>>> v5:
>>>>>>  - Remove unnecessary clearing of REG_SE
>>>>>>
>>>>>>  drivers/mfd/ti_am335x_tscadc.c       | 13 +++++--------
>>>>>>  include/linux/mfd/ti_am335x_tscadc.h |  1 +
>>>>>>  2 files changed, 6 insertions(+), 8 deletions(-)
>>>>>
>>>>> Looks fine.
>>>>>
>>>>> For my own reference:
>>>>>   Acked-by: Lee Jones <lee.jones@...aro.org>
>>>>>
>>>>> Can this patch be applied on its own?
>>>>>
>>>>
>>>> I prefer to wait until input patches are picked up.
>>>
>>> I have no problem with that, but is there a technical reason why?
>>>
>>
>> Nothing, in particular. This patch alone has no impact on the
>> performance of TSC/ADC unit. Patch 2/6 is necessary to observe the
>> changes caused by this series. Hence, please wait until those patches
>> are picked up.
> 
> Input maintainer has applied other patches. You can pick this one.

Gentle ping... Can you pull this patch into 4.0-rc? Other patches of
this series are already in mainline.

Regards
Vignesh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/