linux-kernel - Re: Nokia N900: omap aes is broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201502251118.22991@pali>
Date:	Wed, 25 Feb 2015 11:18:22 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Tony Lindgren <tony@...mide.com>, Nishanth Menon <nm@...com>,
	Felipe Balbi <balbi@...com>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Sebastian Reichel <sre@...nel.org>,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-crypto@...r.kernel.org
Subject: Re: Nokia N900: omap aes is broken

On Wednesday 25 February 2015 10:50:00 Pavel Machek wrote:
> On Tue 2015-02-24 09:37:34, Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@...il.com> [150224 09:42]:
> > > On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote:
> > > > * Pali Rohár <pali.rohar@...il.com> [150218 16:03]:
> > > > > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> > > > > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> > > > > @@ -3938,8 +3938,9 @@ int __init
> > > > > omap3xxx_hwmod_init(void)
> > > > > 
> > > > >  	if (r < 0)
> > > > >  	
> > > > >  		return r;
> > > > > 
> > > > > -	/* Register GP-only hwmod links. */
> > > > > -	if (h_gp && omap_type() == OMAP2_DEVICE_TYPE_GP) {
> > > > > +//	/* Register GP-only hwmod links. */
> > > > > +//	if (h_gp && omap_type() == OMAP2_DEVICE_TYPE_GP) {
> > > > > +	if (h_gp) {
> > > > > 
> > > > >  		r = omap_hwmod_register_links(h_gp);
> > > > >  		if (r < 0)
> > > > >  		
> > > > >  			return r;
> > > > > 
> > > > > aes hwmod is defined in GP-only hwmod...
> > > > 
> > > > Doesn't this depend on the bootloader version of n900 to
> > > > work?
> > > > 
> > > > Regards,
> > > > 
> > > > Tony
> > > 
> > > Ok, it looks like second patch (omap_hwmod_3xxx_data.c)
> > > needs that aes-enabled bootloader.
> > 
> > OK we need some runtime detection somehow for what's
> > enabled..
> > 
> > > But first patch (omap3.dtsi) is needed for proper
> > > definitions. Otherwise omap-aes driver will never work on
> > > DT systems.
> > 
> > Yeah that one makes sense to me, I guess you'll do a proper
> > fix for that one.
> 
> If this depends on bootloader... would command line parameter
> be right solution here?
> 									Pavel

Problem is that we need to disable AES in:

* DT file
* hwmod source code
* ... and maybe on other places too ...

So I think it make sense to check if AES is disabled in DT and 
add this check to other parts of kernel source code where needed.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)