lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Feb 2015 11:45:38 +0100 From: Daniel Lezcano <daniel.lezcano@...aro.org> To: Ingo Molnar <mingo@...nel.org> CC: tglx@...utronix.de, matthias.bgg@...il.com, robert.jarzmik@...e.fr, linux@...ck-us.net, linux@...pel-privat.de, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/3] clocksource: pxa: Fix section mismatch On 02/25/2015 11:35 AM, Ingo Molnar wrote: > > * Daniel Lezcano <daniel.lezcano@...aro.org> wrote: > >> From: Robert Jarzmik <robert.jarzmik@...e.fr> >> >> As pxa_timer_common_init() is only called in init context, mark it as >> such, and quiesce the compiler warnings : >> WARNING: vmlinux.o(.text.unlikely+0x45d4): Section mismatch in reference >> from the function pxa_timer_common_init() to the function >> .init.text:sched_clock_register() >> >> WARNING: vmlinux.o(.text.unlikely+0x4610): Section mismatch in reference >> from the function pxa_timer_common_init() to the function >> .init.text:clocksource_mmio_init() >> >> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org> >> --- >> drivers/clocksource/pxa_timer.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clocksource/pxa_timer.c b/drivers/clocksource/pxa_timer.c >> index 941f3f3..d9438af 100644 >> --- a/drivers/clocksource/pxa_timer.c >> +++ b/drivers/clocksource/pxa_timer.c >> @@ -163,7 +163,7 @@ static struct irqaction pxa_ost0_irq = { >> .dev_id = &ckevt_pxa_osmr0, >> }; >> >> -static void pxa_timer_common_init(int irq, unsigned long clock_tick_rate) >> +static void __init pxa_timer_common_init(int irq, unsigned long clock_tick_rate) >> { >> timer_writel(0, OIER); >> timer_writel(OSSR_M0 | OSSR_M1 | OSSR_M2 | OSSR_M3, OSSR); > > So this is then used indirectly by: > > CLOCKSOURCE_OF_DECLARE(pxa_timer, "marvell,pxa-timer", pxa_timer_dt_init); > > which should probably be marked __initdata? Sorry, I miss the point. What should be marked __initdata ? -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists