lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Feb 2015 20:55:41 +0800 From: Hanjun Guo <hanjun.guo@...aro.org> To: al.stone@...aro.org, rjw@...ysocki.net, lenb@...nel.org, catalin.marinas@....com, will.deacon@....com, robert.moore@...el.com, tony.luck@...el.com, fenghua.yu@...el.com CC: linaro-kernel@...ts.linaro.org, linux-ia64@...r.kernel.org, linaro-acpi@...ts.linaro.org, patches@...aro.org, linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, devel@...ica.org Subject: Re: [PATCH v3 2/9] ACPI: clear up warnings on use of printk reported by checkpatch.pl On 2015年02月25日 08:36, al.stone@...aro.org wrote: > From: Al Stone <al.stone@...aro.org> > > In preparation for later splitting out some of the arch-dependent code from > osl.c, clear up all the warnings reported by checkpatch.pl where pr_* should > be used instead of printk(KERN_* ...). > > Signed-off-by: Al Stone <al.stone@...aro.org> > --- > drivers/acpi/osl.c | 46 +++++++++++++++++++--------------------------- > 1 file changed, 19 insertions(+), 27 deletions(-) > > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c > index 1dc3a3b..865317c 100644 > --- a/drivers/acpi/osl.c > +++ b/drivers/acpi/osl.c > @@ -141,7 +141,7 @@ static u32 acpi_osi_handler(acpi_string interface, u32 supported) > { > if (!strcmp("Linux", interface)) { > > - printk_once(KERN_NOTICE FW_BUG PREFIX > + pr_notice_once(FW_BUG PREFIX I think you can use pr_fmt() and then remove all the PREFIX in this patch, just #define pr_fmt(fmt) "ACPI: " fmt in top of this file before all #includes. Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists