linux-kernel - Re: [PATCH v2] x86, boot: Allow 64bit EFI kernel to be loaded above 4G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Feb 2015 12:57:27 +0000
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
	Jonathan Corbet <corbet@....net>,
	Matt Fleming <matt.fleming@...el.com>,
	Kees Cook <keescook@...omium.org>,
	Junjie Mao <eternal.n08@...il.com>, linux-doc@...r.kernel.org,
	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86, boot: Allow 64bit EFI kernel to be loaded above
 4G

On Wed, 25 Feb, at 11:31:32AM, Ingo Molnar wrote:
> 
> * Matt Fleming <matt@...eblueprint.co.uk> wrote:
> 
> > On Sun, 22 Feb, at 07:43:48PM, Yinghai Lu wrote:
> > > Index: linux-2.6/arch/x86/boot/header.S
> > > ===================================================================
> > > --- linux-2.6.orig/arch/x86/boot/header.S
> > > +++ linux-2.6/arch/x86/boot/header.S
> > > @@ -301,7 +301,7 @@ _start:
> > >  	# Part 2 of the header, from the old setup.S
> > >  
> > >  		.ascii	"HdrS"		# header signature
> > > -		.word	0x020d		# header version number (>= 0x0105)
> > > +		.word	0x020e		# header version number (>= 0x0105)
> > >  					# or else old loadlin-1.5 will fail)
> > >  		.globl realmode_swtch
> > >  realmode_swtch:	.word	0, 0		# default_switch, SETUPSEG
> > > @@ -449,6 +449,7 @@ pref_address:		.quad LOAD_PHYSICAL_ADDR
> > >  #endif
> > >  init_size:		.long INIT_SIZE		# kernel initialization size
> > >  handover_offset:	.long 0			# Filled in by build.c
> > > +ext_code32_start:	.long 0			# werid one!
> >   
> > How about a comment like, "# Upper 32-bits of code32_start" ?
> 
> Also, in the Linux kernel we should not go about inventing 
> new English words like 'werid', right?

Yeah, my intention is to replace "werid one" with the comment I
suggested above.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/