lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150225151229.GE5132@x1>
Date:	Wed, 25 Feb 2015 15:12:29 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Peter Griffin <peter.griffin@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	srinivas.kandagatla@...il.com, maxime.coquelin@...com,
	patrice.chotard@...com, kishon@...com, balbi@...com,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node.

On Wed, 25 Feb 2015, Peter Griffin wrote:

> Now that both usb2 and usb3 phy drivers, and also the ST dwc3 glue code
> are all present upstream, we can add the dwc3 DT node and have a working
> usb3 controller on stih407-b2120 and stih410-b2020.
> 
> Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> ---
>  arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 186412d..18ff5a5 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -7,6 +7,7 @@
>   * publishhed by the Free Software Foundation.
>   */
>  #include "stih407-pinctrl.dtsi"
> +#include <dt-bindings/phy/phy.h>
>  #include <dt-bindings/reset-controller/stih407-resets.h>
>  / {
>  	#address-cells = <1>;
> @@ -336,5 +337,30 @@
>  				resets = <&softreset STIH407_MIPHY2_SOFTRESET>;
>  			};
>  		};
> +
> +		st_dwc3: dwc3@...4000 {
> +			compatible	= "st,stih407-dwc3";
> +			reg		= <0x08f94000 0x1000>, <0x110 0x4>;
> +			reg-names	= "reg-glue", "syscfg-reg";
> +			st,syscfg	= <&syscfg_core>;
> +			resets		= <&powerdown STIH407_USB3_POWERDOWN>,
> +					  <&softreset STIH407_MIPHY2_SOFTRESET>;
> +			reset-names	= "powerdown",
> +					  "softreset";

Nit: What's the purpose of having these on separate lines?

Apart from that, it looks good:

Acked-by: Lee Jones <lee.jones@...aro.org>

> +			#address-cells	= <1>;
> +			#size-cells	= <1>;
> +			pinctrl-names	= "default";
> +			pinctrl-0	= <&pinctrl_usb3>;
> +			ranges;
> +
> +			dwc3: dwc3@...0000 {
> +				compatible	= "snps,dwc3";
> +				reg		= <0x09900000 0x100000>;
> +				interrupts	= <GIC_SPI 155 IRQ_TYPE_NONE>;
> +				dr_mode		= "host";
> +				phy-names	= "usb2-phy", "usb3-phy";
> +				phys		= <&usb2_picophy0>, <&phy_port2 PHY_TYPE_USB3>;
> +			};
> +		};
>  	};
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ