linux-kernel - Re: [PATCH 4/4] net/core/dev.c : Race condition in net_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150225.134743.267148874428657838.davem@davemloft.net>
Date:	Wed, 25 Feb 2015 13:47:43 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ameenali023@...il.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] net/core/dev.c : Race condition in net_tx_action.

From: Ameen Ali <ameenali023@...il.com>
Date: Wed, 25 Feb 2015 19:50:59 +0200

> @@ -3413,7 +3413,7 @@ EXPORT_SYMBOL(netif_rx_ni);
>  
>  static void net_tx_action(struct softirq_action *h)
>  {
> -	struct softnet_data *sd = this_cpu_ptr(&softnet_data);
> +	volatile struct softnet_data *sd = &__get_cpu_var(softnet_data);

volatile is never an appropriate solution to a race condition
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/