linux-kernel - Re: [PATCH 2/2] twl4030_charger: find associated phy by more reliable means.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150225211351.GH13695@earth>
Date:	Wed, 25 Feb 2015 22:13:51 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	NeilBrown <neilb@...e.de>
Cc:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Felipe Balbi <balbi@...com>,
	GTA04 owners <gta04-owner@...delico.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/2] twl4030_charger: find associated phy by more
 reliable means.

Hi Neil,

On Tue, Feb 24, 2015 at 03:01:29PM +1100, NeilBrown wrote:
> twl4030_charger currently finds the associated phy
> using usb_get_phy() which will return the first USB2 phy.
> If your platform has multiple such phys (as mine does),
> this is not reliable (and reliably fails on the GTA04).
> 
> Change to use devm_usb_get_phy_by_node(), having found the
> node by looking for an appropriately named sibling in
> device-tree.
> 
> This makes usb-charging dependent on correct device-tree
> configuration.

The patch looks ok to me, but you should update the DT documentation
in Documentation/devicetree/bindings/power/twl-charger.txt regarding
the sibling dependency.

Apart from that DT binding maintainers should be CC'd.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)