linux-kernel - Re: [PATCH 3/4] HID: uclogic: present only the working interfaces on the Huion tablets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150225213050.GD3097@mail.corp.redhat.com>
Date:	Wed, 25 Feb 2015 16:30:50 -0500
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Nikolai Kondrashov <spbnick@...il.com>
Cc:	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	DIGImend-devel <DIGImend-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 3/4] HID: uclogic: present only the working interfaces on
 the Huion tablets

On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote:
> On 02/25/2015 02:05 AM, Benjamin Tissoires wrote:
> >The Huion tablets show 3 interfaces. Only the first and the third
> >are currently used.
> >Also remove HID_QUIRK_MULTI_INPUT for the third interface to not
> >create more than needed input nodes.
> >
> >Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> >---
> >  drivers/hid/hid-uclogic.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> >diff --git a/drivers/hid/hid-uclogic.c b/drivers/hid/hid-uclogic.c
> >index 397f1df..c03e076 100644
> >--- a/drivers/hid/hid-uclogic.c
> >+++ b/drivers/hid/hid-uclogic.c
> >@@ -840,6 +840,11 @@ static int uclogic_probe(struct hid_device *hdev,
> >  				hid_err(hdev, "tablet enabling failed\n");
> >  				return rc;
> >  			}
> >+		} else if (intf->cur_altsetting->desc.bInterfaceNumber == 2) {
> >+			hdev->quirks &= ~HID_QUIRK_MULTI_INPUT;
> >+		} else {
> >+			/* Ignore all unused interfaces */
> >+			return -ENODEV;
> >  		}
> >  		break;
> >  	}
> >
> 
> I would hesitate to remove the mouse interface as there are relatively fresh
> UC-Logic tablets [1] out there which have a mouse, and which could respond to
> the initialization. These mice are of questionable usefulness, true, but
> leaving the interface enabled could make it easier for other people to
> experiment with using this driver with their tablets.

OK, I will just remove the quirk for the mouse interface then.

> 
> What do you think, Benjamin?
> 

You have a better knowledge of the currently available devices. So I'll
follow your ideas.

> Nick
> 
> [1] http://digimend.github.io/tablets/UC-Logic_TWHL850/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/