linux-kernel - Re: [PATCH 6/6] qlcnic_dcb.c : possible division by zero.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Feb 2015 17:01:06 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ameenali023@...il.com
Cc:	shahed.shaikh@...gic.com, Dept-GELinuxNICDev@...gic.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 6/6] qlcnic_dcb.c : possible division by zero.

From: Ameen Ali <ameenali023@...il.com>
Date: Wed, 25 Feb 2015 23:56:43 +0200

> @@ -822,7 +822,7 @@ qlcnic_dcb_get_pg_tc_cfg_tx(struct net_device *netdev, int tc, u8 *prio,
>  		if (temp->valid && (pg == temp->pgid))
>  			cnt++;
>  	}
> -
> +	if(cnt != 0)
>  	tc_cfg->bwg_percent = (100 / cnt);

This is not acceptable.

Your conditional expression is not spaced properly, there must be a space
between "if" and the openning parenthesis of the condition.

You also must properly re-indent the statement the new if() condition
is protecting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/