linux-kernel - Re: [PATCH 5/5] ohci-tmio.c : missing 'break' statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1502251711400.1301-100000@iolanthe.rowland.org>
Date:	Wed, 25 Feb 2015 17:13:04 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Ameen Ali <ameenali023@...il.com>
cc:	gregkh@...uxfoundation.org, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] ohci-tmio.c : missing 'break' statements

The "break" statements are missing by intention.

On Wed, 25 Feb 2015, Ameen Ali wrote:

> Redundant bitwise operation on 'pm' in 'switch' statement.

Why do you say the operations are redundant?

> Signed-off-by : Ameen Ali <Ameenali023@...il.com>
> ---
>  drivers/usb/host/ohci-tmio.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c
> index e9a6eec..c580615 100644
> --- a/drivers/usb/host/ohci-tmio.c
> +++ b/drivers/usb/host/ohci-tmio.c
> @@ -102,10 +102,13 @@ static void tmio_stop_hc(struct platform_device *dev)
>  			dev_err(&dev->dev, "Unsupported amount of ports: %d\n", ohci->num_ports);
>  		case 3:
>  			pm |= CCR_PM_USBPW3;
> +			break;
>  		case 2:
>  			pm |= CCR_PM_USBPW2;
> +			break;
>  		case 1:
>  			pm |= CCR_PM_USBPW1;
> +			break;
>  	}
>  	tmio_iowrite8(0, tmio->ccr + CCR_INTC);
>  	tmio_iowrite8(0, tmio->ccr + CCR_ILME);

This patch is wrong.  Figuring out why is left as an exercise.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/