linux-kernel - Re: [PATCH v6 0/7] PCI: get DMA configuration from parent device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150225222049.GP6220@google.com>
Date:	Wed, 25 Feb 2015 16:20:49 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Murali Karicheri <m-karicheri2@...com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	iommu@...ts.linux-foundation.org, devicetree@...r.kernel.org,
	linux-pci@...r.kernel.org, Joerg Roedel <joro@...tes.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Will Deacon <will.deacon@....com>,
	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
Subject: Re: [PATCH v6 0/7] PCI: get DMA configuration from parent device

On Thu, Feb 05, 2015 at 04:52:52PM -0500, Murali Karicheri wrote:
> This patch add an important capability to PCI driver on Keystone. I hope to
> have this merged to the upstream branch so that it is available for v3.20.
> Also would like thank everyone for the contribution.
> 
> PCI devices on Keystone doesn't have correct dma_pfn_offset set. This patch
> add capability to set the dma configuration such as dma-mask, dma_pfn_offset,
> and dma ops etc using the information from DT. The prior RFCs and discussions
> are available at [1] and [2] below.
> 
> [2] : https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg790244.html
> [1] : http://www.gossamer-threads.com/lists/linux/kernel/2024591
> 
> Change history:
> 	v6 - Rebased to v3.19-v7
> 	   - Addressed some minor comments about node name and DT size validation.
> 	   - Pulled out 8/8 of v5 and plan to send a patch for enhancing
> 	     of_dma_configure() to use size to calculate dma mask.
> 	   - Added Acks from reviewers.
> 	v5 - moved the dma_mask update in device from ARM specific API to
> 	     of_dma_configure to allow this across other architecture as well
> 	   - improved sanity check for DT dma-range size in of_dma_configure()
> 	   - moved API to get parent bridge device to PCI (host-bridge.c)
> 	v4 - moved size adjustments in of_iommu_configure() to a separate patch
> 	   - consistent node name comment from Rob
> 	   - patch 6 added for dma_mask adjustment and iommu mapping size
> 	     limiting.
> 	v3 - addressed comments to re-use of_dma_configure() for PCI
> 	   - To help re-use, change of_iommu_configure() function argument
> 		- Move of_dma_configure to of/device.c
> 		- Limit the of_iommu_configure to non pci devices
> 	v2 - update size to coherent_dma_mask + 1 if dma-range info is missing
> 	   - also check the np for null.
> 	v1 - updates based on the comments against initial RFC.
> 	   - Added a helper function to get the OF node of the parent
> 	   - Added an API in of_pci.c to update DMA configuration of the pci
> 	     device.
> 
> Cc: Joerg Roedel <joro@...tes.org>
> Cc: Grant Likely <grant.likely@...aro.org>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Will Deacon <will.deacon@....com>
> Cc: Russell King <linux@....linux.org.uk>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> Acked-by: Murali Karicheri <m-karicheri2@...com>
> 
> Murali Karicheri (7):
>   of: iommu: add ptr to OF node arg to of_iommu_configure()
>   of: move of_dma_configure() to device.c to help re-use
>   of: fix size when dma-range is not used
>   PCI: add helper functions pci_get[put]_host_bridge_device()
>   of/pci: add of_pci_dma_configure() update dma configuration
>   PCI: update dma configuration from DT
>   arm: dma-mapping: limit iommu mapping size
> 
>  arch/arm/mm/dma-mapping.c |    7 +++++
>  drivers/iommu/of_iommu.c  |   10 ++++--
>  drivers/of/device.c       |   74 +++++++++++++++++++++++++++++++++++++++++++++
>  drivers/of/of_pci.c       |   19 ++++++++++++
>  drivers/of/platform.c     |   58 ++---------------------------------
>  drivers/pci/host-bridge.c |   14 +++++++++
>  drivers/pci/probe.c       |    2 ++
>  include/linux/of_device.h |    2 ++
>  include/linux/of_iommu.h  |    6 ++--
>  include/linux/of_pci.h    |    5 +++
>  include/linux/pci.h       |    3 ++
>  11 files changed, 140 insertions(+), 60 deletions(-)

Applied with additional acks/tested-by to pci/iommu for v4.1, thanks!

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/