linux-kernel - Re: [PATCH] PCI/AER: Avoid info leak in __print_tlp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150225225859.GB19236@pd.tnic>
Date:	Wed, 25 Feb 2015 23:59:00 +0100
From:	Borislav Petkov <bp@...e.de>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH] PCI/AER: Avoid info leak in __print_tlp_header

On Wed, Feb 25, 2015 at 12:18:14PM -0800, Bjorn Helgaas wrote:
> Why are we worrying about byte order here at all?  I'd think we could
> just print t->dw0 directly with %08x.

Right, my only concern is since this is user-facing, someone/something
might depend on its format/byte order. But since no one has complained
about the bug so far, we might just as well do the simple thing and just
print t->dwX.

Btw, Bjorn, when applying the final version, please add the stable tag
too.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/