linux-kernel - Re: [PATCH v4 1/8] arm64: exynos5433: Enable ARMv8 based Exynos5433 (SoC) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <54EED910.4010603@samsung.com>
Date:	Thu, 26 Feb 2015 17:28:00 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Arnd Bergmann <arnd@...db.de>, kgene@...nel.org,
	Sylwester Nawrocki <s.nawrocki@...sung.com>
Cc:	mark.rutland@....com, marc.zyngier@....com, olof@...om.net,
	catalin.marinas@....com, will.deacon@....com, inki.dae@...sung.com,
	chanho61.park@...sung.com, sw0312.kim@...sung.com,
	jh80.chung@...sung.com, ideal.song@...sung.com,
	a.kesavan@...sung.com, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/8] arm64: exynos5433: Enable ARMv8 based Exynos5433
 (SoC) support

On 02/24/2015 05:31 PM, Arnd Bergmann wrote:
> On Tuesday 24 February 2015 14:16:44 Chanwoo Choi wrote:
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 1b8e973..d83cea0 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -154,6 +154,17 @@ config ARCH_EXYNOS
>>         help
>>           This enables support for Samsung Exynos SoC family
>>  
>> +config ARCH_EXYNOS5433
>> +       bool "ARMv8 based Samsung Exynos5433"
>> +       select ARCH_EXYNOS
>> +       select COMMON_CLK_SAMSUNG
>> +       select HAVE_S3C_RTC if RTC_CLASS
>> +       select PINCTRL
>> +       select PINCTRL_EXYNOS
>> +
>> +       help
>> +         This enables support for Samsung Exynos5433 SoC family
>> +
>>  config ARCH_EXYNOS7
>>         bool "ARMv8 based Samsung Exynos7"
>>         select ARCH_EXYNOS
>> -- 
>>
> 
> Can we collapse all these entries into one for EXYNOS? I don't
> want to end up with endless lists like we have on arm32 when
> there is no platform specific code that is actually controlled
> by this anway.

I agree.

I check the some issue for only using the CONFIG_ARCH_EXYNOS
insead of CONFIG_ARCH_EXYNOS7 and CONFIG_ARCH_EXYNOS5433.

Each CONFIG_ARCH_EXYNOS{7|5433} configuraiton was used on following list:
- CONFIG_ARCH_EXYNOS7
arch/arm64/boot/dts/exynos/Makefile:1:dtb-$(CONFIG_ARCH_EXYNOS7) += exynos7-espresso.dtb
drivers/clk/samsung/Makefile:17:obj-$(CONFIG_ARCH_EXYNOS7)	+= clk-exynos7.o
- CONFIG_ARCH_EXYNOS5433
drivers/clk/samsung/Makefile:13:obj-$(CONFIG_ARCH_EXYNOS5433)	+= clk-exynos5433.o

We may can fix it as following by only using 'CONFIG_ARCH_EXYNOS' without any specific configuration.

arch/arm64/boot/dts/exynos/Makefile:1:dtb-$(CONFIG_ARCH_EXYNOS) += exynos7-espresso.dtb
drivers/clk/samsung/Makefile:17:obj-$(CONFIG_ARCH_EXYNOS)	+= clk-exynos7.o clk-exynos5433.o

I think that we need the opinion of Kukjin Kim (Exynos SoC Maintainer)
and Sylwester Nawrocki(Samsung clock Maintainer)

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/