linux-kernel - Re: [PATCH] usb: isp1760: fix peripheral/device controller chip id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54EEF475.5080107@arm.com>
Date:	Thu, 26 Feb 2015 10:24:53 +0000
From:	Sudeep Holla <sudeep.holla@....com>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:	Sudeep Holla <sudeep.holla@....com>, Felipe Balbi <balbi@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] usb: isp1760: fix peripheral/device controller chip id

Hi Laurent,

On 25/02/15 22:27, Laurent Pinchart wrote:
> Hi Sudeep,
>
> Thank you for the patch.
>
> On Tuesday 24 February 2015 17:53:42 Sudeep Holla wrote:
>> As per the ISP1761 data sheet, the DcChipID register represents
>> the hardware version number (0015h) and the chip ID (8210h) for the
>> Peripheral Controller.
>>
>> This patch fixes the chip ID value used to verify the controller.
>>
>> Cc: Felipe Balbi <balbi@...com>
>> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
>> ---
>>   drivers/usb/isp1760/isp1760-udc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Hi Laurent,
>>
>> I found that the chip ID is wrong when I tried testing OTG on vexpress
>> platforms. As per Section 10.8.2 DcChipID register in [1], it should be
>> 0x00158210.
>
> On the other hand, http://www.nxp.com/documents/data_sheet/SAF1761.pdf#120
> uses 0x00011582. It looks like we need to accept both.
>

Thanks for sharing this datasheet, I will update to accept both ID and
resend.

Regards,
Sudeep

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/