linux-kernel - [PATCH] block: drop extra (and bogus) printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1424991408-3110-1-git-send-email-luis.henriques@canonical.com>
Date:	Thu, 26 Feb 2015 22:56:48 +0000
From:	Luis Henriques <luis.henriques@...onical.com>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] block: drop extra (and bogus) printk

When setting an invalid scheduler through sysfs, two log entries will be
added.  Also, when running 'echo foo > /sys/block/DISK/queue/scheduler'
the second one will includes the extra '\n':

[10465.216944] elevator: type foo not found
[10465.216953] elevator: switch to foo
 failed

This patch simply drops the second printk().

Signed-off-by: Luis Henriques <luis.henriques@...onical.com>
---
 block/elevator.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/elevator.c b/block/elevator.c
index 59794d0d38e3..0ac9ea519201 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -997,7 +997,6 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
 	if (!ret)
 		return count;
 
-	printk(KERN_ERR "elevator: switch to %s failed\n", name);
 	return ret;
 }
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/