linux-kernel - [PATCH] loongson-3/hpet.c: remove IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1425039262-20003-1-git-send-email-Valentin.Rothberg@lip6.fr>
Date:	Fri, 27 Feb 2015 13:14:22 +0100
From:	Valentin Rothberg <Valentin.Rothberg@...6.fr>
To:	ralf@...ux-mips.org, taohl@...ote.com, chenhc@...ote.com,
	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Cc:	Valentin Rothberg <Valentin.Rothberg@...6.fr>
Subject: [PATCH] loongson-3/hpet.c: remove IRQF_DISABLED flag

The IRQF_DISABLED is a NOOP and scheduled to be removed.  According to Ingo
Molnar (e58aa3d2d0cc01ad8d6f7f640a0670433f794922) running IRQ handlers with
interrupts enabled can cause stack overflows when the interrupt line of the
issuing device is still active.

Signed-off-by: Valentin Rothberg <Valentin.Rothberg@...6.fr>
---
 arch/mips/loongson/loongson-3/hpet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/loongson/loongson-3/hpet.c b/arch/mips/loongson/loongson-3/hpet.c
index e898d68..5c21cd3 100644
--- a/arch/mips/loongson/loongson-3/hpet.c
+++ b/arch/mips/loongson/loongson-3/hpet.c
@@ -162,7 +162,7 @@ static irqreturn_t hpet_irq_handler(int irq, void *data)
 
 static struct irqaction hpet_irq = {
 	.handler = hpet_irq_handler,
-	.flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER,
+	.flags = IRQF_NOBALANCING | IRQF_TIMER,
 	.name = "hpet",
 };
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/