linux-kernel - Re: [PATCH] usb: gadget: f_mass_storage: use defined constant instead of numeric value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xa1tk2z3y25o.fsf@mina86.com>
Date:	Fri, 27 Feb 2015 13:22:43 +0100
From:	Michal Nazarewicz <mina86@...a86.com>
To:	Tal Shorer <tal.shorer@...il.com>, linux-usb@...r.kernel.org
Cc:	balbi@...com, gregkh@...uxfoundation.org, tal.shorer@...il.com,
	andrzej.p@...sung.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: f_mass_storage: use defined constant instead of numeric value

On Thu, Feb 26 2015, Tal Shorer <tal.shorer@...il.com> wrote:
> Signed-off-by: Tal Shorer <tal.shorer@...il.com>

Acked-by: Michal Nazarewicz <mina86@...a86.com>

> ---
>  drivers/usb/gadget/function/f_mass_storage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
> index 811929c..6d5ca2b 100644
> --- a/drivers/usb/gadget/function/f_mass_storage.c
> +++ b/drivers/usb/gadget/function/f_mass_storage.c
> @@ -1085,7 +1085,7 @@ static int do_inquiry(struct fsg_common *common, struct fsg_buffhd *bh)
>  	if (!curlun) {		/* Unsupported LUNs are okay */
>  		common->bad_lun_okay = 1;
>  		memset(buf, 0, 36);
> -		buf[0] = 0x7f;		/* Unsupported, no device-type */
> +		buf[0] = TYPE_NO_LUN;	/* Unsupported, no device-type */
>  		buf[4] = 31;		/* Additional length */
>  		return 36;
>  	}
> -- 
> 2.2.2
>

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@...gle.com>--<xmpp:mina86@...ber.org>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/