linux-kernel - Re: [PATCH 1/1] ARM: TLV320AIC23 SoC Audio Codec: Fix errors reported related to input routing signals.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54F06E38.5020608@metafoo.de>
Date:	Fri, 27 Feb 2015 14:16:40 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Gabriel Dobato <dobatog@...il.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	linux-arm-kernel@...ts.infradead.org
CC:	moinejf@...e.fr, Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Max Filippov <jcmvbkbc@...il.com>,
	Xiubo Li <Li.Xiubo@...escale.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] ARM: TLV320AIC23 SoC Audio Codec: Fix errors reported
 related to input routing signals.

On 02/26/2015 12:32 PM, Gabriel Dobato wrote:
> From: dobatog <dobatog@...il.com>
>
> The following patch, based on stable v3.19,  corrects the errors that are reported in the boot trace in reference to the Input Signals of the audio codec TLV320AIC23:
>
> tlv320aic23-codec 1-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input
> tlv320aic23-codec 1-001a: ASoC: no dapm match for LLINEIN --> NULL --> Line Input
> tlv320aic23-codec 1-001a: ASoC: Failed to add route LLINEIN -> NULL -> Line Input
> tlv320aic23-codec 1-001a: Control not supported for path RLINEIN -> [NULL] -> Line Input
> tlv320aic23-codec 1-001a: ASoC: no dapm match for RLINEIN --> NULL --> Line Input
> tlv320aic23-codec 1-001a: ASoC: Failed to add route RLINEIN -> NULL -> Line Input
> tlv320aic23-codec 1-001a: Control not supported for path MICIN -> [NULL] -> Mic Input
> tlv320aic23-codec 1-001a: ASoC: no dapm match for MICIN --> NULL --> Mic Input
> tlv320aic23-codec 1-001a: ASoC: Failed to add route MICIN -> NULL -> Mic Input
>
> I am trying to set the sound system in a CM-510 (Compulab - SoM) based board with DT, using Simple-Card-Audio and  the TLV320AIC23 audio codec included in the SoM . I faced this problem and thanks to the help of Sebastian Hesselbarth who noticed the possible error located in the structure snd_soc_dapm_route tlv320aic23_intercon[] , now errors are not reported.
>
> Tested on CM-510 (Compulab SoM Board).
>
> Signed-off-by: dobatog <dobatog@...il.com>

Hi,

The patch itself looks good, but the commit message needs some work.

The subject line should be something like "ASoC: tlv320aic23: ..." to 
indicate that this is for the ASoC subsystem and the tlv320aic23 driver.

The commit message should be line-wrapped at around 76 characters.

Signed-off-by and From tag need to have your full name.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/