linux-kernel - Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMdRc4E4+nDvP7V0sGGLJ=K1iCgwo2WqZQdU8cy=H9Yd8dGvoA@mail.gmail.com>
Date:	Fri, 27 Feb 2015 15:05:32 +0100
From:	Robert Abel <rabel@...-ec.uni-bielefeld.de>
To:	Roger Quadros <rogerq@...com>
Cc:	balbi@...com, linux-omap@...r.kernel.org,
	linux-usb@...r.kernel.org,
	Linux Kernel Maling List <linux-kernel@...r.kernel.org>,
	Tony Lindgren <tony@...mide.com>, linux@....linux.org.uk
Subject: Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output
 for DTS

Hi Roger,

On Fri, Feb 27, 2015 at 11:43 AM, Roger Quadros <rogerq@...com> wrote:
>>               time_ns_min = gpmc_ticks_to_ns(l ? l - 1 : 0);
>
> should be
>                 time_ns_min = l ? gpmc_ticks_to_ns(l - 1) + 1 : 0;
That's a micro-optimization.
>
>                 + 1ns since we don't want to fall into the previous tick bracket.
>                 for l == 0 we have t_min as 0. no need to pass it through gpmc_ticks_to_ns() or add 1 ns.
That's why the invervals are half-open. I can make them closed, no problem.

Regards,

Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/