linux-kernel - Re: [PATCH] usb/isp1760: set IRQ flags properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150227152435.GA22183@saruman.tx.rr.com>
Date:	Fri, 27 Feb 2015 09:24:35 -0600
From:	Felipe Balbi <balbi@...com>
To:	Valentin Rothberg <Valentin.Rothberg@...6.fr>
CC:	<gregkh@...uxfoundation.org>, <balbi@...com>,
	<laurent.pinchart@...asonboard.com>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] usb/isp1760: set IRQ flags properly

On Fri, Feb 27, 2015 at 02:29:40PM +0100, Valentin Rothberg wrote:
> The IRQF_DISABLED is a NOOP and scheduled to be removed.  According to
> commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled)
> running IRQ handlers with interrupts enabled can cause stack overflows
> when the interrupt line of the issuing device is still active.
> 
> This patch removes using this deprecated flag and additionally removes
> redundantly setting IRQF_SHARED.

why is it redundant ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)