linux-kernel - Re: [PATCH v2] net: bcmgenet: fix throughtput regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425057745.5130.29.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 27 Feb 2015 09:22:25 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jaedon Shin <jaedon.shin@...il.com>
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	linux-kernel@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v2] net: bcmgenet: fix throughtput regression

On Fri, 2015-02-27 at 23:27 +0900, Jaedon Shin wrote:
> This patch adds bcmgenet_tx_poll for all active tx_rings. It can reduce
> the interrupt load and send xmit in upper network stack on time.
> 
> The bcmgenet_tx_reclaim of tx_ring[{0,1,2,3}] process only under 18
> descriptors is to late reclaiming transmitted skb. Therefore,
> performance degradation of xmit after 605ad7f ("tcp: refine TSO
> autosizing").
> 
> Signed-off-by: Jaedon Shin <jaedon.shin@...il.com>
> ---
>  drivers/net/ethernet/broadcom/genet/bcmgenet.c | 111 +++++++++++++++++++------
>  drivers/net/ethernet/broadcom/genet/bcmgenet.h |   2 +
>  2 files changed, 87 insertions(+), 26 deletions(-)


Oh I only saw your patch now. It looks better than the quick fix ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/