linux-kernel - Re: [PATCH, RESEND] usb: musb: fix Kconfig regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150227235103.GB590@fuloong-minipc.musicnaut.iki.fi>
Date:	Sat, 28 Feb 2015 01:51:03 +0200
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-usb@...r.kernel.org, Felipe Balbi <balbi@...com>,
	gregkh@...uxfoundation.org, linux-arm-kernel@...ts.infradead.org,
	Tony Lindgren <tony@...mide.com>, ivo.g.dimitrov.75@...il.com,
	khilman@...nel.org, sre@...ian.org,
	kernel list <linux-kernel@...r.kernel.org>, sre@...g0.de,
	Sakari Ailus <sakari.ailus@....fi>,
	Pavel Machek <pavel@....cz>, pali.rohar@...il.com,
	linux-omap@...r.kernel.org, patrikbachan@...il.com
Subject: Re: [PATCH, RESEND] usb: musb: fix Kconfig regression

Hi,

On Sat, Feb 28, 2015 at 12:19:41AM +0100, Arnd Bergmann wrote:
> A recent bug fix I did that was marked for stable backports
> introduced a slightly wrong dependency on CONFIG_OMAP_CONTROL_PHY.
> 
> I was missing the fact that the PHY driver already stubs out the
> omap_control_usb_set_mode, and we only need to add a dependency
> to prevent the musb-omap2430 driver from being built-in when
> the phy driver is a loadable module, but we should not prevent it
> from being built altogether when the phy driver is disabled.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: ca784be36cc725 ("usb: start using the control module driver")
> Acked-by: Acked-by: Pavel Machek <pavel@....cz>
> Cc: <stable@...r.kernel.org> # v3.9+

This patch allows me to disable redundant CONFIG_OMAP_CONTROL_PHY
from 4.0-rc1 .config and still get a working USB on Nokia N9. So:

Tested-by: Aaro Koskinen <aaro.koskinen@....fi>

Thanks,

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/